chore: general fixes (#4)

.codeql-prebuild-cpp-Linux.sh

@@ -1,4 +1,4 @@
-# install dependencies for C++ analysis
+#!/bin/bash
 set -e
 
 # install dependencies
@@ -16,15 +16,15 @@ sudo apt-get update
 sudo apt-get install --no-install-recommends -y "${dependencies[@]}"
 
 # build
-nxdk_dir="$(pwd)/third-party/nxdk"
-eval "$(${nxdk_dir}/bin/activate -s)"
-cd "${nxdk_dir}"
+export NXDK_DIR="$(pwd)/third-party/nxdk"
+eval "$(${NXDK_DIR}/bin/activate -s)"
+cd "${NXDK_DIR}"
 make NXDK_ONLY=y
 make tools
 
 cd "${GITHUB_WORKSPACE}"
 mkdir -p build
-cmake -DCMAKE_TOOLCHAIN_FILE="${nxdk_dir}/share/toolchain-nxdk.cmake" -B build -S .
+cmake -DCMAKE_TOOLCHAIN_FILE="${NXDK_DIR}/share/toolchain-nxdk.cmake" -B build -S .
 cmake --build build
 
 # skip autobuild

.codeql-prebuild-cpp-Windows.sh

@@ -1,4 +1,4 @@
-# install dependencies for C++ analysis
+#!/bin/bash
 set -e
 
 # update pacman
@@ -11,23 +11,23 @@ dependencies=(
   "git"
   "bison"
   "flex"
-  "mingw-w64-x86_64-gcc"
-  "mingw-w64-x86_64-llvm"
-  "mingw-w64-x86_64-clang"
-  "mingw-w64-x86_64-lld"
+  "mingw-w64-ucrt-x86_64-gcc"
+  "mingw-w64-ucrt-x86_64-llvm"
+  "mingw-w64-ucrt-x86_64-clang"
+  "mingw-w64-ucrt-x86_64-lld"
 )
 pacman -S --noconfirm "${dependencies[@]}"
 
 # build
-nxdk_dir="$(pwd)/third-party/nxdk"
-eval "$(${nxdk_dir}/bin/activate -s)"
-cd "${nxdk_dir}"
+export NXDK_DIR="$(pwd)/third-party/nxdk"
+eval "$(${NXDK_DIR}/bin/activate -s)"
+cd "${NXDK_DIR}"
 make NXDK_ONLY=y
 make tools
 
 cd "${GITHUB_WORKSPACE}"
 mkdir -p build
-cmake -DCMAKE_TOOLCHAIN_FILE="${nxdk_dir}/share/toolchain-nxdk.cmake" -B build -S .
+cmake -DCMAKE_TOOLCHAIN_FILE="${NXDK_DIR}/share/toolchain-nxdk.cmake" -B build -S .
 cmake --build build
 
 # skip autobuild

.codeql-prebuild-cpp-macOS.sh

@@ -1,4 +1,4 @@
-# install dependencies for C++ analysis
+#!/bin/bash
 set -e
 
 # install dependencies
@@ -11,15 +11,15 @@ dependencies=(
 brew install "${dependencies[@]}"
 
 # build
-nxdk_dir="$(pwd)/third-party/nxdk"
-eval "$(${nxdk_dir}/bin/activate -s)"
-cd "${nxdk_dir}"
+export NXDK_DIR="$(pwd)/third-party/nxdk"
+eval "$(${NXDK_DIR}/bin/activate -s)"
+cd "${NXDK_DIR}"
 make NXDK_ONLY=y
 make tools
 
 cd "${GITHUB_WORKSPACE}"
 mkdir -p build
-cmake -DCMAKE_TOOLCHAIN_FILE="${nxdk_dir}/share/toolchain-nxdk.cmake" -B build -S .
+cmake -DCMAKE_TOOLCHAIN_FILE="${NXDK_DIR}/share/toolchain-nxdk.cmake" -B build -S .
 cmake --build build
 
 # skip autobuild

CMakeLists.txt

@@ -109,6 +109,3 @@ add_dependencies(xbe_iso cxbe_convert)
 
 set_target_properties(cxbe_convert PROPERTIES OUTPUT_QUIET ON)
 set_target_properties(xbe_iso PROPERTIES OUTPUT_QUIET ON)
-
-#add_xbe(xbe_file "${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_PROJECT_NAME}.exe" TITLE "${XBE_TITLE}" RESOURCE_DIRS xbe)
-#add_xiso(xiso xbe_file XISO ${XBOX_ISO})

README.md

@@ -66,7 +66,7 @@ This script takes care of everything, except installing the prerequisites.
       - [x] Separate main build and unit test builds, due to cross compiling, see https://stackoverflow.com/a/64335131/11214013
       - [ ] Get tests to properly compile
       - [ ] Enable codecov
-   - [ ] Enable sonarcloud
+   - [x] Enable sonarcloud
    - [ ] Build moonlight-common-c
       - [ ] Build custom enet, depends on https://github.com/XboxDev/nxdk/pull/680 or https://github.com/thrimbor/nxdk/tree/winsock/lib/winapi (seems unlikely nxdk will ever be ready for this, could definitely use some help with this)
 - Menus / Screens