Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Madden 24 game window disappears on session resume #2092

Closed
3 tasks done
brycerocky opened this issue Feb 3, 2024 · 2 comments · Fixed by LizardByte/tray#10 or #2238
Closed
3 tasks done

Madden 24 game window disappears on session resume #2092

brycerocky opened this issue Feb 3, 2024 · 2 comments · Fixed by LizardByte/tray#10 or #2238
Labels
os:Windows OS is Windows

Comments

@brycerocky
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is your issue described in the documentation?

  • I have read the documentation

Is your issue present in the nightly release?

  • This issue is present in the nightly release

Describe the Bug

When resuming an existing game session, Madden 24 window disappears on the streaming client. The game window is still present on the host machine video output. However, the client only sees the underlying desktop.

Expected Behavior

The client should see the game window like the host machine.

Additional Context

This issue became present after dc967cc

The area of focus is the system_tray update. Looking into this method, it appear that invoking shellapi methods like ExtractIconEx is causing this behavior. For example, simply loading the menu icons without setting anything else is enough to cause this behavior.

Host Operating System

Windows

Operating System Version

Windows 11 Pro 23H2

Architecture

64 bit

Sunshine commit or version

0.21 and nightly (not present in 0.20)

Package

Windows - installer

GPU Type

Nvidia

GPU Model

GeForce RTX 2070 Super

GPU Driver/Mesa Version

551.23

Capture Method (Linux Only)

No response

Config

nvenc_realtime_hags = disabled

Apps

No response

Relevant log output

no relevant log output was present.
@brycerocky
Copy link
Contributor Author

Looking at the log output some more, I see the following logs being produced:
Warning: Windows is currently blocking DRM-protected content from capture. You may see black regions where this content would be.

@brycerocky
Copy link
Contributor Author

I have a potential fix (still needs cleaning up) that sidesteps calling the DRM triggering shell methods by prefetching and caching the icons at tray initialization. Based on my limited testing, this fix appears to fully address the issue without changing the behavior of the tray/notification. I'm optimistic the fix is working since the issue is pretty evident otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os:Windows OS is Windows
Projects
None yet
2 participants