Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tray icons to be precached. #10

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

brycerocky
Copy link

@brycerocky brycerocky commented Mar 10, 2024

Description

On Windows, loading icons through the shell API can trigger DRM issues, leading to windows becoming invisible. This changelist works around these issues by preloading icons at initialization and avoiding calling the shell API methods on demand.

Screenshot

The change should be transparent to the user. No behav

Issues Fixed or Closed

This brings submodule support for enabling a subsequent change which will resolve this issue.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2024

CLA assistant check
All committers have signed the CLA.

tray_windows.c Outdated Show resolved Hide resolved
tray_windows.c Outdated Show resolved Hide resolved
On Windows, loading icons through the shell API can trigger DRM issues, leading to windows becoming invisible. This changelist works around these issues by preloading icons at initialization and avoiding calling the shell API methods on demand.
@TheElixZammuto TheElixZammuto merged commit a08c102 into LizardByte:master Mar 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Madden 24 game window disappears on session resume
4 participants