Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support capturing rotated displays on Windows #1602

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

ns6089
Copy link
Contributor

@ns6089 ns6089 commented Sep 4, 2023

Description

Based on #1560 to prevent future merge conflicts.

Portrait mode displays currently can't be captured at all, this PR fixes it. Also fixes landscape (flipped) being upside down.

Streaming resolution is still decided by Moonlight.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ns6089 ns6089 self-assigned this Sep 7, 2023
@ns6089 ns6089 force-pushed the portrait branch 2 times, most recently from 85fa23e to 9e79503 Compare September 10, 2023 09:18
@ns6089 ns6089 mentioned this pull request Sep 11, 2023
11 tasks
So we won't get hard to debug errors later when we decide to support
serial processing on Windows for example.
If IDR frame was generated due too rfi request being too large, we
didn't save it in last rfi range.

Also move rfi_needs_confirmation variable modification to a more
logical place, even if doesn't affect how current code works.
Any unfulfilled rfi request needs confirmation, whether it's direct rfi
flag in transported frame or indirect IDR frame.
@ReenigneArcher ReenigneArcher merged commit e98d757 into LizardByte:nightly Sep 13, 2023
45 checks passed
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
e-dong pushed a commit to e-dong/Sunshine that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[WINDOWS/AMD] Problem with portrait and landscape mode on Ayaneo Next
4 participants