Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake): fix appimage assets directory #1703

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

ReenigneArcher
Copy link
Member

Description

This PR fixes the Sunshine assets directory for AppImage build.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@LizardByte-bot
Copy link
Member

LizardByte-bot commented Oct 4, 2023

⚠️ Qodana is checking this PR ⚠️
Live results available here

@ReenigneArcher ReenigneArcher force-pushed the fix(cmake)-fix-appimage-assets-directory branch from ff44f07 to 1f03836 Compare October 5, 2023 00:56
@ReenigneArcher ReenigneArcher merged commit af0c81f into nightly Oct 5, 2023
45 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(cmake)-fix-appimage-assets-directory branch October 5, 2023 01:26
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
e-dong pushed a commit to e-dong/Sunshine that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants