Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tray icon images #1736

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Conversation

ns6089
Copy link
Contributor

@ns6089 ns6089 commented Oct 11, 2023

  1. Adds generator script
  2. This script uses special packer that forces png compression, reducing the resulting .ico file sizes tremendously
  3. Also uses optipng to reduce the size around 20% more
  4. Since the sizes are reduced, we generate the icons for all non-custom dpi scaling values
  5. Renames favicon.ico to sunshine.ico, since it's now used in other places such as tray icon

Description

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ns6089
Copy link
Contributor Author

ns6089 commented Oct 11, 2023

Waiting for LizardByte/tray#5

@ns6089 ns6089 force-pushed the more_tray_icons branch 2 times, most recently from 1b95b19 to 2ab2daa Compare October 13, 2023 10:21
@ns6089
Copy link
Contributor Author

ns6089 commented Oct 13, 2023

Waiting for LizardByte/tray#5

Done. This is now ready too.

@ns6089 ns6089 marked this pull request as ready for review October 13, 2023 10:44
1. Adds generator script
2. This script uses special packer that forces png compression,
   reducing the resulting .ico file sizes tremendously
3. Also uses optipng to reduce the size around 20% more
4. Since the sizes are reduced, we generate the icons for all
   non-custom dpi scaling values
5. Renames favicon.ico to sunshine.ico, since it's now used in
   other places such as tray icon
@ReenigneArcher ReenigneArcher merged commit a003f02 into LizardByte:nightly Oct 15, 2023
43 checks passed
@ReenigneArcher ReenigneArcher mentioned this pull request Jan 2, 2024
11 tasks
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
e-dong pushed a commit to e-dong/Sunshine that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants