Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual DS4 mode: Allow Back/Select to trigger Touchpad click #1772

Merged
merged 5 commits into from
Oct 22, 2023

Conversation

ekchang
Copy link
Contributor

@ekchang ekchang commented Oct 22, 2023

Description

When forcing manual DS4 emulation, there isn't a natural way to trigger Touchpad click for standard XInput. Current impl supports passing MISC_BUTTON (Xbox Series X Share button), but Steam Input doesn't expose this mapping, and most other XInput controllers on client don't have this button available.

Allow additional accessibility for clients wishing to emulate DS4 by having Back/Select also trigger Touchpad click. In most games supporting native DS4 input, Back/Share does not do anything anyway and typically should translate to a Touchpad click.

My specific usecase here is using Sunshine via Steam Deck Moonlight client. A DualShock 4 or DualSense controller configured via Steam Input cannot map the Touchpad click to Xbox 'Share' and the only way to pass through Touchpad clicks through to Sunshine is by disabling Steam Input altogether.

Screenshot

Screenshot 2023-10-21 194002

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

When forcing manual DS4 emulation, there isn't a natural way to trigger Touchpad click. Current impl supports passing MISC_BUTTON (Xbox Series X Share button), but Steam Input doesn't expose this mapping, and most other XInput controllers on client don't have this button available.

Allow additional accessibility for clients wishing to emulate DS4 by having Back/Select also trigger Touchpad click.
@CLAassistant
Copy link

CLAassistant commented Oct 22, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

In addition to the below comments. I would also request the docs are updated. All config options are in the "advanced usage" section.

Also, perhaps this option should be named "ds4_back_as_touchpad_click" or something along those lines?

src/platform/windows/input.cpp Outdated Show resolved Hide resolved
src_assets/common/assets/web/config.html Show resolved Hide resolved
src_assets/common/assets/web/config.html Outdated Show resolved Hide resolved
@ekchang
Copy link
Contributor Author

ekchang commented Oct 22, 2023

Updated docs:

Screenshot 2023-10-22 010310

ReenigneArcher
ReenigneArcher previously approved these changes Oct 22, 2023
src/config.h Outdated Show resolved Hide resolved
@ReenigneArcher ReenigneArcher merged commit 3212b03 into LizardByte:nightly Oct 22, 2023
43 checks passed
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
e-dong pushed a commit to e-dong/Sunshine that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants