-
-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous UI updates #2181
Miscellaneous UI updates #2181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since some of the options were re-ordered, can you re-order them here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved UPnP, Channels, and the Config Files section. I think that's everything.
docs/source/about/advanced_usage.rst
Outdated
@@ -917,16 +917,9 @@ keybindings | |||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |||
|
|||
**Description** | |||
This will generate distinct video streams, unlike simply broadcasting to multiple Clients. | |||
Sunshine can support multiple clients streaming simultaneously, at the cost of higher CPU and GPU usage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add a note to indicate that the multiple clients will stream and control the same session. There seems to be some confusion about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I added a note to that effect in the docs and the UI.
@@ -197,7 +197,8 @@ <h1>Applications</h1> | |||
</button> | |||
</div> | |||
<div class="form-text"> | |||
A list of commands to be run and forgotten about | |||
A list of commands to be run in the background.<br> | |||
<b>Note:</b> If the path to the command executable contains spaces, you must enclose it in quotes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question... do we accept any standard shell/terminal command including things such as piping, &&, ||, >, etc.
I wonder if we should add an option to select the shell to use and then just pass in their command as an argument to that shell. (Not for this PR, just an idea I've had for a little while)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't currently, since those are shell builtins rather than real executables. I had similar thoughts when I was working on that URL support for Windows (and we do shell out to cmd.exe in some cases there too).
One problem is that we've already exposed shell-like features like output redirection in the UI as a separate option. It might be difficult to make that work properly with a true shell invocation since the command itself could be piping stdout somewhere else.
Rebasing should fix the flatpak build |
Description
This PR contains a grab bag of mostly unrelated UI changes and adds the option for using non-lowpower HEVC encoding on Intel (see #2175)
Changes:
Screenshot
Issues Fixed or Closed
Fixes #2175
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.