Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linux): improve AppImage AppRun #2300

Closed
wants to merge 1 commit into from

Conversation

ReenigneArcher
Copy link
Member

Description

Attempt to extract AppImage out of readonly file system.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.10%. Comparing base (89e8b96) to head (74e95b8).
Report is 304 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #2300    +/-   ##
=======================================
  Coverage    6.10%   6.10%            
=======================================
  Files          85      85            
  Lines       18296   18296            
  Branches     8316    8316            
=======================================
  Hits         1117    1117            
- Misses      15373   15682   +309     
+ Partials     1806    1497   -309     
Flag Coverage Δ
Linux 4.12% <ø> (ø)
Windows 1.51% <ø> (ø)
macOS-12 8.11% <ø> (ø)
macOS-13 7.39% <ø> (-0.02%) ⬇️
macOS-14 7.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Jun 19, 2024

@gschintgen any thoughts on this? This is completely untested, but I wonder if copying the files to another location would allow setcap. And if it does work, is it even worth using AppImage at that point? It's not nearly as universal as I remember AppImages being advertised, anyway... maybe we should just drop AppImage?

Edit: I think I'll close this for now, unless I get some compelling evidence to continue this effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant