Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix code coverage #2512

Merged
merged 1 commit into from
May 11, 2024
Merged

ci: fix code coverage #2512

merged 1 commit into from
May 11, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 7, 2024

Description

I will try to fix code coverage reports in this PR.

References:

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.02%. Comparing base (26e0ff8) to head (0cf1d69).

Additional details and impacted files
@@            Coverage Diff             @@
##           nightly   #2512      +/-   ##
==========================================
+ Coverage     6.20%   7.02%   +0.81%     
==========================================
  Files           87      87              
  Lines        17606   17675      +69     
  Branches      8164    8395     +231     
==========================================
+ Hits          1093    1242     +149     
+ Misses       15411   13705    -1706     
- Partials      1102    2728    +1626     
Flag Coverage Δ
Linux 5.36% <ø> (+1.10%) ⬆️
Windows 2.60% <ø> (+0.50%) ⬆️
macOS-12 8.02% <ø> (-0.59%) ⬇️
macOS-13 7.94% <ø> (+0.08%) ⬆️
macOS-14 8.28% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 70 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the ci-fix-code-coverage branch 5 times, most recently from 6c49c41 to b94d64a Compare May 11, 2024 20:42
@ReenigneArcher ReenigneArcher force-pushed the ci-fix-code-coverage branch from b94d64a to 0cf1d69 Compare May 11, 2024 20:43
@ReenigneArcher ReenigneArcher marked this pull request as ready for review May 11, 2024 23:04
@ReenigneArcher ReenigneArcher merged commit b4c12cb into nightly May 11, 2024
51 of 53 checks passed
@ReenigneArcher ReenigneArcher deleted the ci-fix-code-coverage branch May 11, 2024 23:12
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant