Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add publisher metadata #3080

Merged
merged 1 commit into from
Aug 25, 2024
Merged

feat: add publisher metadata #3080

merged 1 commit into from
Aug 25, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Aug 24, 2024

Description

Add cmake arguments to allow providing publisher metadata.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

scripts/hash_tool.py Fixed Show fixed Hide fixed
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 9.45%. Comparing base (c9f853d) to head (20437cc).
Report is 121 commits behind head on master.

Files with missing lines Patch % Lines
src/entry_handler.cpp 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3080      +/-   ##
=========================================
- Coverage    9.61%   9.45%   -0.17%     
=========================================
  Files         101      77      -24     
  Lines       17914   14009    -3905     
  Branches     8371    6429    -1942     
=========================================
- Hits         1722    1324     -398     
+ Misses      13321   10072    -3249     
+ Partials     2871    2613     -258     
Flag Coverage Δ
Linux ?
Windows 4.97% <40.00%> (+0.01%) ⬆️
macOS-12 10.40% <25.00%> (-0.01%) ⬇️
macOS-13 10.33% <25.00%> (+0.01%) ⬆️
macOS-14 10.60% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/crypto.h 0.00% <ø> (ø)
src/entry_handler.cpp 4.76% <40.00%> (+2.28%) ⬆️

... and 54 files with indirect coverage changes

---- 🚨 Try these New Features:

@ReenigneArcher ReenigneArcher force-pushed the feat/add-publisher-ids branch 5 times, most recently from 80dbe67 to 8771944 Compare August 24, 2024 18:16
@ReenigneArcher ReenigneArcher changed the title feat: add publisher ids feat: add publisher metadata Aug 24, 2024
@ReenigneArcher ReenigneArcher marked this pull request as ready for review August 24, 2024 18:18
@ReenigneArcher ReenigneArcher force-pushed the feat/add-publisher-ids branch 7 times, most recently from b903500 to e0dd364 Compare August 24, 2024 21:28
@LizardByte LizardByte deleted a comment from ns6089 Aug 24, 2024
@ReenigneArcher ReenigneArcher force-pushed the feat/add-publisher-ids branch 2 times, most recently from bfbaf1f to cc364d7 Compare August 24, 2024 22:10
@ReenigneArcher ReenigneArcher force-pushed the feat/add-publisher-ids branch from cc364d7 to 20437cc Compare August 24, 2024 22:22
Copy link

sonarcloud bot commented Aug 24, 2024

@ReenigneArcher ReenigneArcher merged commit 6593fa5 into master Aug 25, 2024
46 of 49 checks passed
@ReenigneArcher ReenigneArcher deleted the feat/add-publisher-ids branch August 25, 2024 00:14
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant