Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg_patches: add amfenc delay/buffering fix #18

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

psyke83
Copy link
Contributor

@psyke83 psyke83 commented Nov 24, 2022

Description

This resolves the issue in which the last captured frame is delayed by 1ms, which
is especially noticeable in low framerate content (such as desktop streaming)
on the amfenc encoder.

Issues Fixed or Closed

Fixes all reports related to delay with callback capture using the amfenc encoder:

N.B. nvenc also experiences delay that is reported in some of the above issues. For those cases, it is resolved via a separate PR: LizardByte/Sunshine#507

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@psyke83
Copy link
Contributor Author

psyke83 commented Nov 24, 2022

(added a test commit to see if cleaning the working tree before patching helps resolve the issue)

@psyke83 psyke83 force-pushed the amfenc_delay_fix branch 2 times, most recently from 523fd6d to 1be7118 Compare December 2, 2022 16:35
Resolves delay observed in amfenc encoding observed since
CB-based capture was introduced. Should also improve latency due
to frames no longer being buffered.
@ReenigneArcher
Copy link
Member

@zycboss this is not a support channel...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants