Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: use single file for each command #6

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Apr 29, 2024

Description

Use a single file for each command, instead of combining body and footer. This will result is shorter overall embeds, but provides other benefits.

  1. can view the full information on github
  2. can create a gh-pages site with jekyll

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the fix!-use-single-file-for-each-command branch 3 times, most recently from 47766e0 to 85f143e Compare April 29, 2024 21:50
@ReenigneArcher ReenigneArcher force-pushed the fix!-use-single-file-for-each-command branch from 85f143e to e84dd5c Compare April 29, 2024 21:51
@ReenigneArcher ReenigneArcher marked this pull request as ready for review April 29, 2024 21:55
@ReenigneArcher ReenigneArcher merged commit 21cc0c2 into master Apr 29, 2024
7 checks passed
@ReenigneArcher ReenigneArcher deleted the fix!-use-single-file-for-each-command branch April 29, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant