Add interactivity check for physical devices with display timeout #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a niche requirement. Besides, your implementation may encounter the following two issues:
|
LmeSzinc
added
the
emulator issue / 模拟器问题
LmeSzinc
reviewed
Apr 18, 2024
Comment on lines
+147
to
+150
| if not self.device.get_interactive(): | ||
| self.device.wake() | ||
| self.device.sleep(1) | ||
| continue |
Comment on lines
+722
to
+730
| @retry | ||
| def get_interactive(self): | ||
| """ | ||
| Makes sure device is interactive before starting tasks | ||
| """ | ||
| _INTERACTIVE_RE = re.compile( | ||
| r'mInteractive=(?P<interactive>.+)' | ||
| ) | ||
| output = self.adb_shell(['dumpsys', 'input_method']) |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I recently started running ALAS on a cheap android tablet with a 1 minute display timeout to save energy. I also have it configured to close the game on tasks completion.
However, after ALAS goes to idle and closes the game, it would always fail with logs that look like this and a pure black screenshot:
This seems to be because the device went to sleep, so I added a new function to check for device interactivity (which is set to false when display is off), and used it in the ui_get_current_page and handle_app_login loops to wake the device if not interactive.
I've been running with these changes for the past week and it hasn't required any manual interventions yet. I've defaulted the result of the function to true in the case where we can't find the expected adb outputs to keep behavior identical for older devices and emulators, but I haven't actually tested on an emulator yet since I don't have one set up. Would appreciate some help with this from folks that run ALAS on emulators!
I'm a bit of a python noob, so there might be some mistakes in here. Happy to update this as you see fit. Thanks!