This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Add an offset for epoch #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgorman
force-pushed
the
add_epoch_offset
branch
2 times, most recently
from
5fe289d to
909a64a
Compare
|
@mjgorman Salt-api currently send back localized datetime in string format. I've not yet decided which way is the best to correctly compensate that the date is not an UTC timestamp or at least an UTC datetime, maybe saltpad could accept a timezone or an offset, will think about it. |
|
It was an oversight to not enforce that JIDs in Salt were in UTC. There's a discussion over in the Salt repo to get this switched over to UTC for the Carbon release. Preliminary replies are making the transition look simple. |
|
Maybe getting more votes on the issue on saltstack would help |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for me, thought others would like it as well. Our servers are all UTC-0, but I'm lazy and don't want to math in my head.