Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler errors caused by CelesteTAS refactor #3

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

psyGamer
Copy link
Contributor

@psyGamer psyGamer commented Dec 14, 2024

This PR fixes ABI incompatabilities caused by EverestAPI/CelesteTAS-EverestInterop#91
Note that the PR isn't merged yet, since I think this is a good opportunity to remove weird dependencies on CelesteTAS such as hooks or publicizing.

If there are any APIs which would be useful to TAS Helper, while ideally removing hooks / publicizing, please let me know.
Also I'm unsure on how to properly test all feature, so if anything broke, let me know as well.

This PR should only be merged after the CelesteTAS refactor has been merged and then discuss how to release both at the same time.

@psyGamer psyGamer marked this pull request as draft December 14, 2024 13:31
@LozenChen LozenChen marked this pull request as ready for review December 16, 2024 13:38
@LozenChen LozenChen merged commit ba79bb8 into LozenChen:main Dec 16, 2024
@LozenChen
Copy link
Owner

note that ghost mod also needs an update when the refactor of CelesteTAS releases

@LozenChen LozenChen mentioned this pull request Dec 25, 2024
15 tasks
@LozenChen
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants