Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add source from base64 #31

Merged
merged 4 commits into from
Jul 23, 2024
Merged

add source from base64 #31

merged 4 commits into from
Jul 23, 2024

Conversation

emanuele-em
Copy link
Contributor

  • Source also from base64 string

@Lurk
Copy link
Owner

Lurk commented Jun 24, 2024

Hey @emanuele-em, thank you for the contribution.
Can you please add a test case to https://github.com/Lurk/cloudinary_rs/blob/main/src/tests/mod.rs?

@emanuele-em
Copy link
Contributor Author

@Lurk test added :)

@Lurk
Copy link
Owner

Lurk commented Jul 5, 2024

@emanuele-em Hey, I am cycling through Lapland now. I will review your changes when I am back in civilization.

TY for your contribution, and sorry for the delay.

@emanuele-em
Copy link
Contributor Author

@emanuele-em Hey, I am cycling through Lapland now. I will review your changes when I am back in civilization.

TY for your contribution, and sorry for the delay.

no hurry! watch out for polar bears, I need this merge 🐻‍❄️

@Lurk Lurk merged commit 8e9f648 into Lurk:main Jul 23, 2024
0 of 6 checks passed
@Lurk
Copy link
Owner

Lurk commented Jul 23, 2024

@emanuele-em Hey, thank you for the contribution and for waiting.
Check out the latest version at https://github.com/Lurk/cloudinary_rs/releases/tag/0.5.0 or https://crates.io/crates/cloudinary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants