Skip to content

Merge pull request #27 from Lurk/serializer #72

Merge pull request #27 from Lurk/serializer

Merge pull request #27 from Lurk/serializer #72

Triggered via push October 8, 2023 18:28
Status Success
Total duration 4m 1s
Artifacts

check.yml

on: push
stable / fmt
19s
stable / fmt
nightly / doc
29s
nightly / doc
ubuntu / stable / features
34s
ubuntu / stable / features
Matrix: clippy
Matrix: msrv
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
call to `.clone()` on a reference in this situation does nothing: src/nodes/list_item.rs#L92
warning: call to `.clone()` on a reference in this situation does nothing --> src/nodes/list_item.rs:92:60 | 92 | format!("\n{}{} ", " ".repeat(level), list_type.clone()).as_str(), | ^^^^^^^^ help: remove this redundant call | = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
call to `.clone()` on a reference in this situation does nothing: src/nodes/list_item.rs#L91
warning: call to `.clone()` on a reference in this situation does nothing --> src/nodes/list_item.rs:91:58 | 91 | format!("{}{} ", " ".repeat(level), list_type.clone()).as_str(), | ^^^^^^^^ help: remove this redundant call | = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed = note: `#[warn(noop_method_call)]` on by default
use of `unwrap_or` to construct default value: src/nodes/yamd.rs#L149
warning: use of `unwrap_or` to construct default value --> src/nodes/yamd.rs:149:32 | 149 | metadata: metadata.unwrap_or(Metadata::default()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
use of `unwrap_or` to construct default value: src/nodes/metadata.rs#L29
warning: use of `unwrap_or` to construct default value --> src/nodes/metadata.rs:29:24 | 29 | tags: tags.unwrap_or(vec![]), | ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default
stable / clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
call to `.clone()` on a reference in this situation does nothing: src/nodes/list_item.rs#L92
warning: call to `.clone()` on a reference in this situation does nothing --> src/nodes/list_item.rs:92:60 | 92 | format!("\n{}{} ", " ".repeat(level), list_type.clone()).as_str(), | ^^^^^^^^ help: remove this redundant call | = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
call to `.clone()` on a reference in this situation does nothing: src/nodes/list_item.rs#L91
warning: call to `.clone()` on a reference in this situation does nothing --> src/nodes/list_item.rs:91:58 | 91 | format!("{}{} ", " ".repeat(level), list_type.clone()).as_str(), | ^^^^^^^^ help: remove this redundant call | = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed = note: `#[warn(noop_method_call)]` on by default
use of `unwrap_or` to construct default value: src/nodes/yamd.rs#L149
warning: use of `unwrap_or` to construct default value --> src/nodes/yamd.rs:149:32 | 149 | metadata: metadata.unwrap_or(Metadata::default()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
use of `unwrap_or` to construct default value: src/nodes/metadata.rs#L29
warning: use of `unwrap_or` to construct default value --> src/nodes/metadata.rs:29:24 | 29 | tags: tags.unwrap_or(vec![]), | ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default
beta / clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/