Add CORS handling for /api/create endpoint #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Quincy Mast <[email protected]>
Luzifer
requested changes
Dec 31, 2024
There was a problem hiding this comment.
These headers can be added in the proxy-server / ingress in front of OTS.
At the very least this must be configurable. Generally disabling CORS for the endpoint allows everyone to post to every instances using any web-interface. The operators need to be able to explicitly activate / configure this (default should be off).
Signed-off-by: Quincy Mast <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets Access-Control-Allow-* headers on requests to the /api/create endpoint.
This allows the JSON API to be used for secret creation from a web app hosted at a different domain.