Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Heyah mama' by K3 #1132

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Add 'Heyah mama' by K3 #1132

merged 2 commits into from
Dec 28, 2024

Conversation

richelbilderbeek
Copy link
Contributor

Here are the lyrics from a song from a band I am actively investigating. I intend to add all lyrics, if this Pull Request turns out to be a positive experience.

I chose to use 'Heyah mama', with a lowercase 'm' in the second word, as this is how the track is named on the CD. I am willing to change to title case.

Thanks for this useful initiative and cheers, Richel Bilderbeek

@snshn
Copy link
Member

snshn commented Dec 27, 2024

Hi there! Thank you for the contribution!

Could you please use double spaces after commas for the authors? — This way it's parsed as an array. It's a weird markup that lets it be both human- and machine-readable at the same time.

And two blank newlines before the long underscored line would make it easier to read in raw plaintext format.

As for the file name, the file itself is for the filesystem and URLs, everything on the website comes from the metadata values. So you can make it capital in the file name, keep lowercase in the metadata. No preference really, it's art, but I generally try to keep things easy to read on the fa level, and pretty/styled on the visual (HTML, metadata) side.

@richelbilderbeek
Copy link
Contributor Author

Updated! If there is more you need, let me know and I will happily add this.

You check the PRs by hand? If you want, I can write a continuous integration script that does most checks (and gives feedback) automatically :-)

@snshn
Copy link
Member

snshn commented Dec 28, 2024

Thank you for improving it, will merge in now.

There's a test suite that checks things, it's just certain things are unimportant, visual, or can't be easily validated. E.g. the whole "one or two spaces after a comma", it's to make "Music, LLC, Sound, Inc." work, to basically allow commas within array items... ergo it can be valid with either one or two spaces, very hard to test.

@snshn snshn merged commit 3dca666 into Lyrics:master Dec 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants