Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dist array tests and protect against segfault. #179

Merged
merged 3 commits into from
Oct 27, 2024

Conversation

hmacdope
Copy link
Member

No description provided.

@pep8speaks
Copy link

Hello @hmacdope! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 72:41: W291 trailing whitespace
Line 234:5: E303 too many blank lines (2)
Line 234:80: E501 line too long (82 > 79 characters)
Line 241:80: E501 line too long (84 > 79 characters)
Line 247:5: E303 too many blank lines (2)
Line 247:80: E501 line too long (82 > 79 characters)
Line 255:80: E501 line too long (93 > 79 characters)
Line 262:5: E303 too many blank lines (3)
Line 262:80: E501 line too long (82 > 79 characters)
Line 270:80: E501 line too long (97 > 79 characters)
Line 279:5: E303 too many blank lines (2)
Line 305:5: E303 too many blank lines (2)
Line 312:80: E501 line too long (85 > 79 characters)
Line 317:5: E303 too many blank lines (3)
Line 325:80: E501 line too long (93 > 79 characters)
Line 329:5: E303 too many blank lines (2)
Line 337:80: E501 line too long (97 > 79 characters)

@@ -874,6 +882,10 @@ def calc_self_distance_array_triclinic(
dims[0] = <ssize_t > final_size


# return early, will seg
if nvals0 == 0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nitpicky but this probably should be typed either to f32/64 based on the input

@hmacdope hmacdope merged commit 469102e into MDAnalysis:main Oct 27, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants