Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use-defined precision in XYZWriter #4771

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ChiahsinChu
Copy link

@ChiahsinChu ChiahsinChu commented Oct 29, 2024

Changes made in this Pull Request:

  • add precision for XYZWriter
  • UT for new feature

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4771.org.readthedocs.build/en/4771/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up from discord, could you please open up an issue to discuss what you are trying to achieve here please? The ASE import cannot happen unfortunately.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.72%. Comparing base (e776f12) to head (de76d90).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4771      +/-   ##
===========================================
+ Coverage    93.66%   93.72%   +0.06%     
===========================================
  Files          177      189      +12     
  Lines        21726    23141    +1415     
  Branches      3052     3139      +87     
===========================================
+ Hits         20349    21689    +1340     
- Misses         930     1004      +74     
- Partials       447      448       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@orbeckst
Copy link
Member

@ChiahsinChu thank you for your contribution. Could you please open an issue that requests the feature that this PR is adding, namely "setting output precision for XYZ Writer"? Before commenting on the implementation in a PR we first need to decide if the requested feature should be added. In the issue provide support in favor of this feature, e.g., documentation for feature specification, description of need etc.

Thank you!

@orbeckst
Copy link
Member

I am asking for an issue because the issue #4772 that you linked does not seem to have anything to do with the content of this PR. Having separate issues for separate features is a good thing!

@ChiahsinChu ChiahsinChu changed the title New features for XYZWriter Allow use-defined precision in XYZWriter Oct 31, 2024
@orbeckst
Copy link
Member

@ChiahsinChu do you want to re-open this PR?

@ChiahsinChu ChiahsinChu reopened this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants