-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LGPL switch #4794
LGPL switch #4794
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4794 +/- ##
===========================================
- Coverage 93.66% 93.64% -0.03%
===========================================
Files 177 189 +12
Lines 21742 22808 +1066
Branches 3055 3055
===========================================
+ Hits 20365 21358 +993
- Misses 930 1003 +73
Partials 447 447 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- source code: LGPLv2.1+
- overall package: LGPLv3+ (for now)
Main question: Do we need to include the text of GPLv3 because LGPLv3 incorporates it?
Thanks @orbeckst I just added the text because "why not" and centered the LGPLv3 header. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing, otherwise LGTM. Thanks for the massive effort!
Co-authored-by: Rocco Meli <[email protected]>
@MDAnalysis/coredevs the license change has been approved by final vote and we will merge this PR in order to switch the license of MDAnalysis to LGPL (as detailed above). Thank you everyone for their support in this 3-year long process. |
As per https://www.mdanalysis.org/2023/09/22/licensing-update/#detailing-our-proposed-relicensing-process
We are now at step 3, where we package under LGPLv3+ until we remove our apache dependencies.
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4794.org.readthedocs.build/en/4794/