Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a deployment pipeline #107

Merged
merged 5 commits into from
Oct 28, 2023
Merged

Add a deployment pipeline #107

merged 5 commits into from
Oct 28, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 27, 2023

No description provided.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

This should give us wheels for the upcoming release.

@hmacdope @orbeckst I don't have keys for PYPI & TESTPYPI so I can't upload the right token - I might just do the OpenID connect migration here,

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

Tests passed fine - this is just waiting on setting up the trusted publisher.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

.github/workflows/deploy.yaml Show resolved Hide resolved
@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

@orbeckst are you ok setting the trusted publisher details before merging?

details should all be straightforward, workflow is deploy.yaml, environment is deploy

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

I can't block since I'm the author, but please hold merge for a second! There's an extra bit to updating the deployment file which I'm only finding out now.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

Ok anticipated trusted publisher has been added on testpypi and the trusted publisher has been set properly on pypi.

@IAlibay IAlibay merged commit bf4df12 into master Oct 28, 2023
25 checks passed
@IAlibay IAlibay deleted the release-pipeline branch October 28, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants