Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new mdanalysis theme + RTD on PR #109

Merged
merged 8 commits into from
Nov 19, 2023
Merged

Add new mdanalysis theme + RTD on PR #109

merged 8 commits into from
Nov 19, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 28, 2023

No description provided.

@pep8speaks
Copy link

pep8speaks commented Oct 28, 2023

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 210:5: E124 closing bracket does not match visual indentation
Line 256:5: E124 closing bracket does not match visual indentation

Comment last updated at 2023-11-05 09:49:03 UTC

@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

RTD build seems fine, should be good to go.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

Build failures are pending a new release of mdanalysis-sphinx-theme

@IAlibay IAlibay closed this Oct 29, 2023
@IAlibay IAlibay reopened this Oct 29, 2023
@IAlibay
Copy link
Member Author

IAlibay commented Nov 5, 2023

Looks like the whole sphinx thing doesn't like macos & ubuntu - probably will need to shuffle CI around a bit.

@IAlibay IAlibay closed this Nov 5, 2023
@IAlibay IAlibay reopened this Nov 5, 2023
@IAlibay IAlibay requested a review from hmacdope November 5, 2023 09:49
@IAlibay
Copy link
Member Author

IAlibay commented Nov 19, 2023

Ok, this resolved upstream, should be good to go @hmacdope

@hmacdope hmacdope merged commit 37e6a3d into master Nov 19, 2023
26 checks passed
@IAlibay IAlibay deleted the new_theme branch November 19, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants