Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Article Entity에 userId 추가 #16

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Article Entity에 userId 추가 #16

wants to merge 5 commits into from

Conversation

ljyo2o9
Copy link
Contributor

@ljyo2o9 ljyo2o9 commented Jun 22, 2024

  • 기능 명세를 보니 userId가 필요한 것을 꺠달아 이를 수정하였습니다.

@ljyo2o9 ljyo2o9 requested a review from ori0o0p June 22, 2024 12:06
ori0o0p
ori0o0p reviewed Jul 5, 2024
View reviewed changes
src/main/java/com/meogo/meogo_backend/domain/community/article/service/ArticleService.java
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service 로직에서 직접 SecurityContextHolder에 접근하는 건 살짝 안 좋은 설계 같아요.
SecurityContextHolder에 접근하는 클래스를 따로 나누면 좋을 것 같네요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ori0o0p ori0o0p ori0o0p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljyo2o9 @ori0o0p