Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split volume slider into remote and local #113

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

RivinHD
Copy link
Contributor

@RivinHD RivinHD commented Mar 21, 2023

Hi, I had the same issue as #99, so I implemented this as a solution.
This should also cover the feature request #69.

Unfortunately, I couldn't test it with TeamSpeak because it couldn't install my compiled .dll.
I also compiled this project from master, but TeamSpeak couldn't install it either.
Maybe I am using a wrong compiler?
I am using: MSVC 19.35.32215.0 (Compiler of Visual Studio Code 2022)

@RivinHD
Copy link
Contributor Author

RivinHD commented Mar 21, 2023

I also added #include <stdexcept> in src/SoundInfo.h and src/TalkStateManager.h otherwise I couldn't compile with MSVC

@MGraefe MGraefe merged commit 3e6d0ce into MGraefe:master Apr 3, 2023
@MGraefe
Copy link
Owner

MGraefe commented Apr 3, 2023

Sorry for the late reply, I'm not a whole lot active on this project anymore since most people switched to Discord.

This is awesome! Code looks excellent, thanks for sticking with the existing coding style. A lot of things are a bit messy and not how I would code them today, but it is what it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants