Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requirements and remove deprecated unittest2 #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ClementWalter
Copy link

No description provided.

@ClementWalter
Copy link
Author

Fix for #77

@ClementWalter
Copy link
Author

@FabianIsensee here is the minimal change. I have run the test locally and it is all good.

@dyollb
Copy link

dyollb commented Nov 26, 2024

Why was this never merged or finished?

unittest2 was developed to make it possible to use the standard library unittest (or look-a-like) in Python 2.7 code.
It is outdated and adds obsolete dependencies like these

unittest2==1.1.0
    # via batchgenerators
argparse==1.4.0
    # via unittest2
traceback2==1.4.0
    # via unittest2
linecache2==1.0.0
    # via traceback2

Can I try another attempt to resolve the conflicts and remove this dependency?

I can see there is a rewrite of batchgenerators (batchgeneratorsv2), but nnunet still depends on batchgenerators...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants