Tests: skip optional ones and update requirement #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=======================================
Coverage 48.73% 48.73%
=======================================
Files 15 15
Lines 2294 2294
=======================================
Hits 1118 1118
Misses 1176 1176Continue to review full report at Codecov.
|
ghost
commented
Sep 20, 2017
tests/test_offline.py
Outdated
| for path in paths: | ||
| json_blob = self.make_objects(os.path.join('tests', | ||
| 'viper-test-files', 'test_files', path)) | ||
| except FileNotFoundError: |
There was a problem hiding this comment.
That one does not exist on python2 it seems...
|
Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not fix #110, it only affects the tests.