-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Attraction component #37
base: main
Are you sure you want to change the base?
Conversation
Use async await instead of multiple .then
✅ Deploy Preview for prep-22-jul-prep-2-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AkhileshManda Hey I am requesting a change on this PR before further reviewing preview build as the build itself is failing as of now.
Hey @jhashivam-2001 I have removed this error. Please look at it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AkhileshManda Hey, the error is resolved but don't you think the out of scale blank white spaces in the attractions cards kindda goes off with the aesthetics of the web app ??
Maybe try resizing the cards or maybe try bootstrap gallery for a better orientation.
@sumana2001 Hey, what's your opinion here ?
@AkhileshManda Also there are merge conflicts with this commit and needs to be resolved manually. |
Yes I agree. It looks very empty since the proportions are very different |
Cool! Will work on it |
No description provided.