Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Attraction component #37

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

AkhileshManda
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Jul 29, 2022

Deploy Preview for prep-22-jul-prep-2-project ready!

Name Link
🔨 Latest commit b85dcaf
🔍 Latest deploy log https://app.netlify.com/sites/prep-22-jul-prep-2-project/deploys/62e3def24f8f06000870c95b
😎 Deploy Preview https://deploy-preview-37--prep-22-jul-prep-2-project.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@jhashivam-2001 jhashivam-2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AkhileshManda Hey I am requesting a change on this PR before further reviewing preview build as the build itself is failing as of now.

  1. The preview build is failing due to some invalid constructor initialization of Use-Effect Hook in the home.js file that you have modified. I am attaching the failure log here for your better understanding :-
    image

@AkhileshManda
Copy link
Member Author

Hey @jhashivam-2001 I have removed this error. Please look at it

Copy link
Contributor

@jhashivam-2001 jhashivam-2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AkhileshManda Hey, the error is resolved but don't you think the out of scale blank white spaces in the attractions cards kindda goes off with the aesthetics of the web app ??

Maybe try resizing the cards or maybe try bootstrap gallery for a better orientation.
@sumana2001 Hey, what's your opinion here ?

image

@jhashivam-2001
Copy link
Contributor

@AkhileshManda Also there are merge conflicts with this commit and needs to be resolved manually.

@sumana2001
Copy link
Member

@AkhileshManda Hey, the error is resolved but don't you think the out of scale blank white spaces in the attractions cards kindda goes off with the aesthetics of the web app ??

Maybe try resizing the cards or maybe try bootstrap gallery for a better orientation. @sumana2001 Hey, what's your opinion here ?

image

Yes I agree. It looks very empty since the proportions are very different

@AkhileshManda
Copy link
Member Author

Cool! Will work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants