avoid inline JavaScript

MPIB · Oct 20, 2021 · 1c837f1 · 1c837f1
1 parent a9c40ca
commit 1c837f1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/static/js/lagerregal.js b/static/js/lagerregal.js
@@ -70,5 +70,10 @@
                 event.preventDefault();
             }
         });
+
+        $(document).on('click', '[data-print-pdf]', function(event) {
+            var url = $(this).data('print-pdf');
+            printJS({printable: url, type:'pdf'});
+        });
     });
 })();
diff --git a/templates/devices/detail/device_detail.html b/templates/devices/detail/device_detail.html
@@ -71,12 +71,12 @@
                     </li>
                 {% endif %}
                 <li>
-                    <button class="dropdown-item" type="button" onclick="printJS({printable: '{% url "device-generate-label" device.id %}', type:'pdf'})">
+                    <button class="dropdown-item" type="button" data-print-pdf="{% url "device-generate-label" device.id %}">
                         <i class="fa fa-print"></i> {% trans "Print Label" %}
                     </button>
                 </li>
                 <li>
-                    <button class="dropdown-item" type="button" onclick="printJS({printable: '{% url "device-generate-protocol" device.id "handover" %}', type:'pdf'})">
+                    <button class="dropdown-item" type="button" data-print-pdf="{% url "device-generate-protocol" device.id "handover" %}">
                         <i class="fa fa-print"></i> {% trans "Print Handover Protocol" %}
                     </button>
                 </li>