Fix memory leak in sh2peaks #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The precomputer instance in Processor was allocated as a raw pointer and thus never freed.
daljit46
force-pushed
the
leaksh2peaks
branch
from
a13b128 to
0d27084
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Lestropie
approved these changes
Jan 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was found using Address Sanitizer on the dev branch. The
Processorclass defined insh2peaks.cppallocated itsprecomputermember variable on the heap using a raw pointer. The allocated memory was never freed, leading to a memory leak. The fix allocates the memory using ashared_ptr(unique_ptrwasn't used as we need our functors to be copyable for multithreaded purposes).