-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DICOM: add null imageIO handler to allow parsing of DICOM data even with unsupported transfer syntax #2767
base: master
Are you sure you want to change the base?
DICOM: add null imageIO handler to allow parsing of DICOM data even with unsupported transfer syntax #2767
Conversation
…ith unsupported transfer syntax This at least allow mrinfo to run. Any operation that attempts to access the voxel data will of course fail.
Co-authored-by: Robert Smith <[email protected]>
For info: the motivation for this is to at least allow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had wanted to test this on some local data with unsupported transfer syntax, but am now having trouble finding any. I do plan on generating some at some point using the local scanner in order to evaluate scope of current support and prospect of better support (eg. #2675) and to augment the testing suite, but have not yet found the time to do it.
I nevertheless checked the code at the time and was happy with it (over and above aef44bb). Only other thing to consider would be version-matching the documentation hyperlink, but that's not requisite for the PR.
Actually, in retrospect, the documentation shows |
Found some unsupported data. Works as intended at my end, though the user feedback is perhaps sub-optimal:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
57c0579 resolves 2 of the 3 concerns I raised about documentation & terminal messages. I think that improves self-consistency and maybe decodes what's going on a little bit for any users who manage to encounter it.
…read_with_unsupported_transfer_syntax
This requires review by someone other than myself or @jdtournier as we can't approve our own changes to |
This at least allow mrinfo to run. Any operation that attempts to access the voxel data will of course fail.