Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright to 2024 on dev #2774

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Update copyright to 2024 on dev #2774

merged 1 commit into from
Jan 16, 2024

Conversation

Lestropie
Copy link
Member

Replicates #2771 for dev.

@Lestropie
Copy link
Member Author

@daljit46: The CI failed test only states which test failed, it fails to quote the error message produced by that test. Is that just a matter of adding --output-on-failure to the ctest call within the GitHub Action?

@daljit46
Copy link
Member

Yes, that should do it. I think I forgot to add that when we reverted back to CMake 3.16 for the CI as for >=3.17 it should be added automatically.

@Lestropie
Copy link
Member Author

Re-running failed jobs:

  • clang-tidy was aborted by a keyboard interrupt, perhaps due to timing out (since it's checking every modified file, which for this PR is all of them)
  • tckgen test 3 failed, which is -seed_random_per_voxel, which has been known to be off by one every once in a while. The thread sanitiser has seemingly not yet caught this one?

@Lestropie Lestropie merged commit a51b036 into dev Jan 16, 2024
5 of 6 checks passed
@Lestropie Lestropie deleted the dev_copyright_update branch January 16, 2024 02:18
@Lestropie Lestropie mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants