-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New folder structure for C++ code #3012
Commits on Oct 17, 2024
-
New folder structure for C++ code
- All C++ code has been moved to a new `cpp` folder. - C++ commands now reside in `cpp/cmd`. - We now build a single (shared by default) library that packages all non-gui code previously in `core` and `src` (now in `cpp/lib`). - All gui code in `cpp/lib/gui` is still built separately as before. - Version matching logic for library and executables has been updated.
Configuration menu - View commit details
-
Copy full SHA for 2a0593e - Browse repository at this point
Copy the full SHA 2a0593eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56284e2 - Browse repository at this point
Copy the full SHA 56284e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39b0871 - Browse repository at this point
Copy the full SHA 39b0871View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01601b8 - Browse repository at this point
Copy the full SHA 01601b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3b4257 - Browse repository at this point
Copy the full SHA e3b4257View commit details -
Instruct CMake to deprioritise headers in /Library/Frameworks on Mac CI
By setting, CMAKE_FIND_FRAMEWORK=LAST we instruct CMake to not look for header files inside /Library/Frameworks as a first search path. This can cause issue when frameworks like Mono are present on the system, resulting in CMake unable to find the homebrew library headers.
Configuration menu - View commit details
-
Copy full SHA for c3d1ea7 - Browse repository at this point
Copy the full SHA c3d1ea7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c95f16c - Browse repository at this point
Copy the full SHA c95f16cView commit details -
Change version retrieving logic for mrtrix3 executables
The strategy now matches what we do to get the library version.
Configuration menu - View commit details
-
Copy full SHA for 0db1261 - Browse repository at this point
Copy the full SHA 0db1261View commit details -
Link mrtrix::executable-version to executables only
This ensures that the version string of library and commands live in separate binary objects. The version matching logic has been moved from app.cpp to command.h to accomodate for this.
Configuration menu - View commit details
-
Copy full SHA for 0e4ecd1 - Browse repository at this point
Copy the full SHA 0e4ecd1View commit details -
New structure for library code
- `cpp/lib` is now split between `core` and `gui`, the former contains all code previously under `core` and `src` while the latter contains only GUI code for `mrview` and `shview` - `mrtrix-headless` has been renamed to `mrtrix-core`
Configuration menu - View commit details
-
Copy full SHA for 7241db9 - Browse repository at this point
Copy the full SHA 7241db9View commit details
Commits on Oct 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cabbc74 - Browse repository at this point
Copy the full SHA cabbc74View commit details
Commits on Oct 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5310272 - Browse repository at this point
Copy the full SHA 5310272View commit details -
Rename opengl/gl.h -> opengl/glutils.h
This is to avoid conflicts with system headers.
Configuration menu - View commit details
-
Copy full SHA for 9e05a54 - Browse repository at this point
Copy the full SHA 9e05a54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99b27e6 - Browse repository at this point
Copy the full SHA 99b27e6View commit details -
Partially turn off clang-format for in cpp/gui/shapes headers
We ensure that glutils.h is included prior to gl_core_3_3.h since it indirectly includes Qt's OpenGL headers (which breaks the build).
Configuration menu - View commit details
-
Copy full SHA for 9972548 - Browse repository at this point
Copy the full SHA 9972548View commit details