Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajoute le type Route nationale #1088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

florimondmanca
Copy link
Collaborator

@florimondmanca florimondmanca commented Nov 25, 2024

Cette PR ajoute le type de localisation "Route nationale"

Le principe est de réutiliser l'entité NumberedRoad, mais dans le formulaire d'utiliser une SaveNumberedRoadCommand pour les RD et une autre pour RN.

Pour permettre cette généralisation il y a eu pas mal de petites adaptations nécessaires.

Aperçus

Screenshot 2024-11-27 at 16-23-06 Arrêté temporaire TEST-1-1-1-2-1-1-2 - DiaLog

Screenshot 2024-11-27 at 16-22-59 Arrêté temporaire TEST-1-1-1-2-1-1-2 - DiaLog

@florimondmanca florimondmanca force-pushed the feat/nationales branch 5 times, most recently from 410f2ae to f4e92f2 Compare November 27, 2024 15:23
@florimondmanca florimondmanca marked this pull request as ready for review November 27, 2024 15:25
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.26627% with 8 lines in your changes missing coverage. Please review.

Project coverage is 98.77%. Comparing base (3eb3382) to head (18f2c79).

Files with missing lines Patch % Lines
...egulation/Command/Location/SaveLocationCommand.php 92.30% 2 Missing ⚠️
...ation/Command/Location/SaveNumberedRoadCommand.php 50.00% 2 Missing ⚠️
src/Infrastructure/Adapter/RoadSectionMaker.php 75.00% 2 Missing ⚠️
...r/Regulation/Fragments/UpdateMeasureController.php 66.66% 1 Missing ⚠️
...lidator/SaveLocationCommandConstraintValidator.php 95.83% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1088      +/-   ##
============================================
- Coverage     98.82%   98.77%   -0.06%     
- Complexity     1774     1799      +25     
============================================
  Files           359      363       +4     
  Lines          7674     7769      +95     
============================================
+ Hits           7584     7674      +90     
- Misses           90       95       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Géocodage de route nationale
2 participants