refactor: Switch to brightway #822
Open
+1,220
−1,412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1k0
reviewed
Nov 12, 2024
ccomb
added a commit
that referenced
this pull request
Nov 21, 2024
## 🔧 Problem The organic cotton is a EI-modified one with only irrigation added. It's impacts are hardcoded and not retrieved from either simapro or brightway. ## 🍰 Solution Use the Ecoinvent organic cotton and add a strategy to add irrigation to it during import. ## 🚨 Points to watch/comments This may only applies on brightway, as I'm unsure where to find the modified organic cotton in SimaPro. It would be great to first merge #822 ## 🏝️ How to test Run the `make clean_data import_ecoinvent` then check in brightway / EI 3.9.1 and EI 3.10 that the organic cotton has an irrigation in the technosphere. Compare the new impact with the previous ones. ecobalyse-data: organic_cotton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problem
We're getting the impacts from simapro, on a dedicated server. There is a dual retrieval that depends on a dedicated server with simapro installed
🍰 Solution
Switch to 100% brightway
🏝️ How to test
Compare the new impacts with the old ones. You can draw the difference between brightway and simapro by running
make compare_food.ecobalyse-private: switch_to_brightway