-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AEM): v2 of AEM base on mission-action #477
Conversation
xtiannyeto
commented
Jan 7, 2025
- Create V2 of every cell of tableau export
- Create a V2 for TableauExport class
- Create a V2 test for every class
- Create V2 of every cell of tableau export - Create a V2 for TableauExport class - Create a V2 test for every class
Coverage Report for frontend
File CoverageNo changed files found. |
-Just getEnv mission without any composition
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feu
if (missionId == null) { | ||
logger.error("GetEnvMissionById received a null missionId") | ||
throw IllegalArgumentException("GetEnvMissionById should not receive null missionId") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commentaire totalement optionnel:
y a un truc que je maitrise pas trop en Kotlin mais je crois que tout ce code peut être remplacé juste par require(missionId)
et ca s'occupe de throw la IllegalArgumentException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je parle de ça: https://www.dhiwise.com/post/kotlin-assert-vs-require-when-to-use-each-in-your-code
je connaissais pas assert
non plus, c'est une shorthand method assez pratique
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chamé je vais checker ca et si changer si necessaire