Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AEM): v2 of AEM base on mission-action #477

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

xtiannyeto
Copy link
Collaborator

  • Create V2 of every cell of tableau export
  • Create a V2 for TableauExport class
  • Create a V2 test for every class

 - Create V2 of every cell of tableau export
 - Create a V2 for TableauExport class
 - Create a V2 test for every class
@xtiannyeto xtiannyeto linked an issue Jan 7, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jan 7, 2025

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 59.56% (🎯 40%) 2509 / 4212
🟢 Statements 58.77% (🎯 40%) 2609 / 4439
🟢 Functions 45.43% (🎯 40%) 612 / 1347
🟢 Branches 49.66% (🎯 40%) 1023 / 2060
File CoverageNo changed files found.
Generated in workflow #1495 for commit d071f8a by the Vitest Coverage Report Action

  -Just getEnv mission without any composition
Copy link

github-actions bot commented Jan 7, 2025

Overall Project 49.34% -0.69%
Files changed 85.14% 🍏

File Coverage
AEMSeaSafety2.kt 100% 🍏
AEMIllegalImmigration2.kt 100% 🍏
AEMTableExport2.kt 98.85% -1.15% 🍏
AEMOutOfMigrationRescue2.kt 98.39% -1.61% 🍏
AEMEnvTraffic2.kt 98.39% -1.61% 🍏
AEMSovereignProtect2.kt 97.52% -2.48% 🍏
AEMVesselRescue2.kt 97.45% -2.55% 🍏
AEMCulturalMaritime2.kt 97.45% -2.55% 🍏
AEMPollutionControlSurveillance2.kt 96.39% -3.61% 🍏
AEMMigrationRescue2.kt 96.1% -3.9% 🍏
AEMNotPollutionControlSurveillance2.kt 94.79% -5.21% 🍏
AEMUtils.kt 93.89% -3.05% 🍏
AEMIllegalFish2.kt 92.81% -7.19% 🍏
GetEnvMissionById.kt 58.14% -41.86%
FillAEMExcelRow.kt 50.1% -11.84%
ExportMissionAEM2.kt 0% -88.24%

Copy link
Collaborator

@lwih lwih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feu

Comment on lines +17 to +20
if (missionId == null) {
logger.error("GetEnvMissionById received a null missionId")
throw IllegalArgumentException("GetEnvMissionById should not receive null missionId")
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commentaire totalement optionnel:
y a un truc que je maitrise pas trop en Kotlin mais je crois que tout ce code peut être remplacé juste par require(missionId) et ca s'occupe de throw la IllegalArgumentException

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je parle de ça: https://www.dhiwise.com/post/kotlin-assert-vs-require-when-to-use-each-in-your-code
je connaissais pas assert non plus, c'est une shorthand method assez pratique

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chamé je vais checker ca et si changer si necessaire

@xtiannyeto xtiannyeto merged commit 51f7c02 into main Jan 9, 2025
9 checks passed
@xtiannyeto xtiannyeto deleted the feature/474-aem-v2 branch January 9, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AEM V2
3 participants