[BUG | TRA-14543] Le volume total d'un DASRI devrait être un Float, et déprécié #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
benoitguigal
approved these changes
Jun 13, 2024
GaelFerrand
changed the title
Merged
GaelFerrand
added a commit
that referenced
this pull request
Jul 2, 2024
* Fix (#3383) * Fix signature (#3388) * Fix paoh edit link * [tra-14460]Ajouter un tooltip concernant la diffusion du nom usuel pour prévenir les utilisateurs que l'information sera accessible pour d'autres acteurs (#3381) * [tra-14478] Renommer Transit par Réexpédition (sous-type de BSFF) + fix some missing arguments in unit test (#3385) * [tra-14490] Renommer Groupement par Regroupement (sous-type de BSFF) (#3386) * [BUG | TRA-14543] Le volume total d'un DASRI devrait être un Float, et déprécié (#3398) * [BUG | TRA-14545] Le champ allowBsdasriTakeOverWithoutSignature devrait être retourné par la requête companyInfos même pour des entreprises non-diffusibles (#3399) * [TRA-14325] Ajout d'une colonne avec l'adresse email du destinataire, négociant & courtier dans tous les registres (#3392) * feat: BSDD * feat: other BSDs * fix: lint * Prevent draft containers from having appendix1 (#3403) * Update paoh modal width * Better paoh destination error messages * Refacto de la validation BSFF, combinaison de commits add tests for bsff parsing fix createBsff.integration.ts and updateBsff.integration.ys move bsff validation into its own file implement bsffPackagingValidation add test for bsffPackaging validation updateBsffPackaging with zod validation fix integration tests fix sonarcloud warnings try to reduce duplication score refactor duplicates line fix linting add documentation for zod validation update changelog handle parsing in signBsff and publishBsff fix tests * packaging volume is not yet required * fix checkAndSetPreviousPackagings transformer * fix typos * [TRA-8355] Ajouter les informations relatives à l'installation de destination post-entreposage provisoire sur le registre sortant et exhaustif (#3349) * feat: started implementing feature. tests needed * feat: added integration tests * feat: improved comments * fix: reverted unwanted change * fix: fixed integration test * fix: fixed address edge-case * feat: added BSDA * lint * lint * feat: added country (always FR) * [TRA-8392] Ajout du SIRET et de la Raison sociale des 3 intermédiaires sur le registre exhaustif (#3367) * feat: implemented intermediaries for the BSDD * test: added tests * refactoring * test: added test * feat: added BSDA * lint * fix: fixed test * [TRA-11099] - Modifier les informations relatives au transport sur l'ensemble des registres (#3409) * feat(Registry): add fields to registries * fix(Docs): move TransportMode enum to fix docs generation * docs(Changelog): update Changelog * test(BSDD): fix bsdd compat test * test(BSDD): fix bsdd compat test * [TRA 9139] - localisation des terres (parcelles) dans les registres (#3410) * feat(Registry): add parcel infos to registries * docs(Changelog): update Changelog * fix(Registry): change parcel registry property names to plural * docs(Registry docs): enrich parcel registry docs * fix(Registry): fix after rebase * [TRA-13275/TRA-14461] Mettre à jour le rôle d'un utilisateur depuis la liste de membres (page entreprise + TD Admin) (#3384) * feat(CompanyMembers): make it possible to change a user role on the company admin page * fix(CompanyMembers): properly update members list when filtered * feat(MembersAdmin): Add company members admin page * fix(Companies database): fix companies database test * refacto(Permissions): refacto admin or permissions check * test(Company members mutations): add tests to inviteUser/removeUser/resendInvitation/deleteInvitation and create tests for changeUserRole * docs(Changelog): update Changelog * style(CompanyMembersList): add padding on company members list * fix(changeUserRole): modify changeUserRole to make it more readable and not have try/catch sink. create CompanyMember mapping functions add some tests * fix(changeUserRole): various fixes * [TRA-14042] Appliquer le traitement Annexe 2 récursivement (#3402) * fix(updateAppendix2Forms): make updateAppendix2Forms recursive to propagate updates properly * docs(Changelog): update Changelog * Swap buttons (#3405) * Fix takenOverAt on appendix1 containers (#3404) * Enhance logger (#3415) * Enhance logger * Fix test * Handle mounted usecase * Use randomUUID() * Use originalUrl * [TRA-14278] Ajout des informations relatives à l'envoi à l'étranger sur les registres Entrant, Sortant, Exhaustif & Gestion, pour les BSDD & BSDA (#3372) * feat: BSDD * feat: BSDA * fix: type error * fix: fixed test * [tra-14488] - Permettre l'activation / désactivation de la Signature automatique de l'Annexe 1 (#3406) * Toggle appendix1 signature automation * Add migration script * Fix integration test * Fix e2e * Fix tests * Avoid force click * Implement revision on grouping and synthesis dasris * Gerico api connexion * fix: fixed e2e that failed because of new DOM structure in CompanyInfo * Post-review fixes * Add more gerico integration tests * Changes error message (#3379) * Add missing procfile entry * Fix company digest download token cache * Fix paoh destination error message * Fix modal padding * Add index migration for company digest distantId * [Bugfix] Correction de la tâche "npx nx dev" (#3428) * Script de nettoyage des évènements Mongo (#3293) * Add script * Add test * Fix & enhancements * Formating * Fix cursor error * Fix cursor * fix(ChangeUserRole): fix siret->orgId param (#3426) + add a skip nx cache param on afterpull to avoid issues * [TRA-11099 fix] Ajout de champs manquants + utilisation de n° de TVA sur transporteur étrangers (#3429) * fix(registry): add transporter number plate on transport registry and exhaustive registry + use VAT in place of transporter SIRET if missing + add missing transporter 4 contact * test(Form compat): fix compat tests * [TRA-14633] Ajout d'un outil de visualisation des données entreprise pour les admins (#3430) * feat: added admin page to check companies data * fix: removed hardcoded value * lint * lint * fix: minor change * fix: rewording * Add vertical spacing to paoh form (#3431) * [tra-13502]Mise à jour du texte présent dans le bandeau (#3433) * Fix A1 5 days rule in frontend (#3432) * [TRA-14348] Corrections de recette: wording & règles de révision sur le DASRI de sythèse (#3434) * [TRA-11334] Une déchetterie (WASTE_CENTER) non vérifiée devrait pouvoir créer un BSDA COLLECTION_2710 (#3436) * feat: added exemption condition * fix: fixed code place * enfore non empty packaging numero et and non negative weights en volume * update bsff validation error messages * Use static gauge (#3435) * use strict equality * Mise à jour du Changelog (#3439) --------- Co-authored-by: Riron <[email protected]> Co-authored-by: Laurent Paoletti <[email protected]> Co-authored-by: JulianaJM <[email protected]> Co-authored-by: Benoît Guigal <[email protected]> Co-authored-by: Benoit Guigal <[email protected]> Co-authored-by: silto <[email protected]> Co-authored-by: Julien Seren-Rosso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contexte
Par souci de cohérence, le champ volume du BsdasriReceptionInput devrait être un Float. Il devrait aussi être déprécié puisque de toute façon ce champ est calculé côté backend, il est inutile de l'envoyer.
Ticket Favro
[BUG] Passer le volume de réception d'un DASRI en Float