Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRA-15377] Adds actors to BSVHU #3795

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[TRA-15377] Adds actors to BSVHU #3795

merged 1 commit into from
Dec 10, 2024

Conversation

kornifex
Copy link
Collaborator

@kornifex kornifex commented Dec 3, 2024 •
edited
Loading

Permettre l'ajout et la modification de courtier, négociant et intermédiaires sur le BSVHU.

Screencast.From.2024-12-03.17-04-44.webm
  • Mettre à jour la documentation
  • Mettre à jour le change log
  • Documenter les manipulations à faire lors de la mise en production (sur le ticket Favro de release)
  • S'assurer que la numérotation des nouvelles migrations est bien cohérente
  • Informer le data engineer de tout changement de schéma DB

@kornifex kornifex requested a review from JulianaJM December 3, 2024 14:31
@kornifex kornifex self-assigned this Dec 3, 2024
@kornifex kornifex force-pushed the feat/tra-15377-vhu-actors branch 4 times, most recently from f3440cf to 31e463e Compare December 3, 2024 16:07
@kornifex kornifex requested a review from providenz December 3, 2024 16:07
@kornifex kornifex force-pushed the feat/tra-15377-vhu-actors branch from 31e463e to 08476f9 Compare December 4, 2024 09:54
@JulianaJM
Copy link
Collaborator

JulianaJM commented Dec 4, 2024 •
edited
Loading

Ta vidéo de démo est toute buggée (ça floute quand on avance) ;)

providenz
providenz approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@providenz providenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lorsque les entreprises n'ont pas le profil adéquat (négociant, courtier etc), l’enregistrement échoue mais aucun message d'erreur n'est affiché.

@kornifex kornifex force-pushed the feat/tra-15377-vhu-actors branch from 08476f9 to 2b28970 Compare December 10, 2024 09:21
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 10, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kornifex kornifex merged commit dadcb80 into dev Dec 10, 2024
19 checks passed
@kornifex kornifex deleted the feat/tra-15377-vhu-actors branch December 10, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulianaJM JulianaJM JulianaJM approved these changes

@providenz providenz providenz approved these changes

Assignees

@kornifex kornifex

Labels
ready for review ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kornifex @JulianaJM @providenz