Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign profile page #706

Merged
merged 50 commits into from
Dec 8, 2024
Merged

Redesign profile page #706

merged 50 commits into from
Dec 8, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented Nov 23, 2024

We completely redesign the profile page as follow up for #670 and #671.

  • We make the new voucher redemption more popular by placing it at the top in a new card.
  • The previous Account & Settings are aggregated together under Account to avoid having to clutter the view by yet another card.
  • We introduce a Request data modal and make the button less prominent. This is to avoid confusion since in the past many users mistook it for the Save changes button (it was previously placed at the bottom of the page with primary color). If the user really requests the data, we now show a toast and stay on the page.
  • The Unsaved changes warning is now shown immediately when typing (not just when clicking away from an input field). We also style it such that the warning itself is a button along its full width (makes it easier clickable and reduces mouse motion).
  • To some extent, we also optimize for mobile view by stacking the columns on top of each other on small displays. Please use the browser dev tools to test this feature. Note that very small widths under around 570px are not supported. For this to work, we'd have to also change the code in other places like the navbar.

Further changes:

  • Contrast is increased, e.g. by using better contrast ratios for colors and borders.
  • Reduce checkbox item margin.
  • I decaffeinated a small CoffeeScript file as I had to add another JS functionality there.
  • Many other small UI improvements that hopefully contribute to a cleaner look.

Known limitations

  • The Change login data button continues to redirect to the MaMpf landing page, which should only be shown when the user is not logged in. This could be tackled in a future PR, e.g. by introducing another modal on the profile edit page.

Redesign preview

Expand

Before

localhost_3000_profile_edit (1)

After

localhost_3000_profile_edit

@Splines Splines added the ui/ux Changes mainly targeting the UI, e.g. redesigns label Nov 23, 2024
@Splines Splines self-assigned this Nov 23, 2024
config/locales/en.yml Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Nov 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@79cb0b3). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #706   +/-   ##
======================================
  Coverage       ?   54.27%           
======================================
  Files          ?      170           
  Lines          ?     7348           
  Branches       ?        0           
======================================
  Hits           ?     3988           
  Misses         ?     3360           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fosterfarrell9 fosterfarrell9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Splines Splines merged commit 8d83274 into dev Dec 8, 2024
4 checks passed
@Splines Splines deleted the redesign/profile-page branch December 8, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux Changes mainly targeting the UI, e.g. redesigns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants