Attempt to improve performance of calling Python callbacks #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…improve performance
C wrapper for Python callbacks accepts OIF arguments, converts them to Python data types and invoke passed Python callback with these arguments. In principle, these should give a performance boost in comparison to using ctypes.
dmitry-kabanov
force-pushed
the
py-oif-wrapper
branch
from
66e28cd
to
f3c6b14
Compare
dmitry-kabanov
force-pushed
the
py-oif-wrapper
branch
from
86381e9
to
831743b
Compare
|
Actually, I had to disable using a C function for type conversion as it gives a segmentation fault in unit tests. Because we with Stephan have decided to concentrate on comparing the performance between C and Julia for now, I postpone working on this to later time, in the branch |
dmitry-kabanov
force-pushed
the
py-oif-wrapper
branch
from
e86a443
to
e236182
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR's main goal is to improve performance of Open Interfaces in the case when non-Python implementations invoke Python callbacks via C wrapper with OIF data types. Previously, this C wrapper (which is actually a Python function wrapped with
ctypes) was converting data types in Python directly. This PR changes conversion function to be completely in C.Changes:
_convert.cthat convert OIF data types to Python data typesOIFConfigDictC data structureprint_statsmethod toscipy_odeandjl_diffeqimplementations