Update references to AVChannelLayout for compatibility with FFmpeg 7 #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge, because archlinux AUR package depends on it |
|
Would be awesome to prioritize this PR, and get things building with the latest ffmpeg. It might be nice to actually improve the PR and somehow detect if it should use the old code path, that way it works for older versions of ffmpeg as well. Then the patch doesn't break older setups. |
|
This looks very similar to this PR: #1031? Should we try to maintain compatibility with older versions? |
|
This PR also needs this: #934 |
|
I combined these 2 PR for a single patch file: #1036 Tested it builds, microphone works, audio works, recording works ( whole screen, WebM, VP8 codec ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the AVCodec interface has changed with FFmpeg 7. This PR updates references to AVChannelLayout properties to resolve the compile errors and replaces a call to the deprecated avcodec_close function with avcodec_free_context.