Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add templates module and update version #98

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Add templates module and update version #98

merged 6 commits into from
Jan 16, 2024

Conversation

abubakarsohail
Copy link
Contributor

This pull request adds a new templates module and updates the version to 0.4.1. The templates module provides a function to get prompt templates with customizable input variables. This update enhances the functionality of the PromptLayer library.

@abubakarsohail abubakarsohail linked an issue Jan 9, 2024 that may be closed by this pull request
expose a new function templates.get to integrate with new endpoint #97
Closed
Jped
Jped approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@Jped Jped left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this, but one thing that comes to mind here is if we do the input_variable parsing in template.get and then we require the customer to do a track.prompt it seems like a bit of redundant work on the customer end.

@abubakarsohail
Copy link
Contributor Author

I am approving this, but one thing that comes to mind here is if we do the input_variable parsing in template.get and then we require the customer to do a track.prompt it seems like a bit of redundant work on the customer end.

For that we need a request_id. Do you think we should expose a new function like templates.run which does all of this automatically? Basically library version of evaluations? With the new system it becomes extremely easy to do it.

@abubakarsohail
Refactor get() function signature in templates.py
8acdf88 
Update get_prompt_template() function signature in utils.py
@abubakarsohail abubakarsohail merged commit 87d2036 into master Jan 16, 2024
3 checks passed
@abubakarsohail abubakarsohail deleted the 97-expose-a-new-function-templatesget-to-integrate-with-new-endpoint branch January 16, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jped Jped Jped approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expose a new function templates.get to integrate with new endpoint
2 participants
@abubakarsohail @Jped