-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity api #2
Activity api #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There only seem to be some minor issues with formulations. If those are fixed, we can merge :)
docs/source/glossary.rst
Outdated
as time passes ("after 20 time units"), | ||
or | ||
at predefined points in time ("at 2000 time units"), | ||
|
||
Notification | ||
Information sent to an :term:`activity`, usually in response to an :term:`event`. | ||
Notifications can only be received when an :term:`activity` is :term:`suspended <Suspension>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who can receive the notification? The activity
? What about postponed
activities?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being postponed is a special case of being suspended. Should it be made clear that both apply?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, definition of Postponement and Suspension should maybe made more clear. You could put into the description of Postponement that this is a special case of being suspended. This might help.
Co-Authored-By: maxfischer2781 <[email protected]>
Co-Authored-By: maxfischer2781 <[email protected]>
I have changed the documentation for There is no real consensus in other Since the |
The |
Co-Authored-By: maxfischer2781 <[email protected]>
Changed the API of rich
Activity
class to be similar to "bare" activities (aka coroutines).Key changes invert how to query and wait for completion:
await activity.result
=>await activity
returns the result (value or exception) on completionawait activity
=>await acitvity.done
delays until completion