Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose error messages #129

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented Dec 3, 2019

This patch exposes error messages returned from Swarm.

Instead "Bad Request" you now get for example "expected set Content-length".

@AuHau
Copy link
Contributor Author

AuHau commented Dec 3, 2019

Should improve upon #119 as well.

@AuHau AuHau force-pushed the feat/better_errors branch from 05d952f to f15b8d3 Compare December 3, 2019 19:05
Copy link
Collaborator

@PaulLeCam PaulLeCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just noticed some small things.

__tests__/browser.ts Show resolved Hide resolved
packages/api-bzz-base/src/index.ts Outdated Show resolved Hide resolved
@AuHau AuHau force-pushed the feat/better_errors branch from f15b8d3 to 024ca3b Compare December 5, 2019 14:15
Copy link
Collaborator

@PaulLeCam PaulLeCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PaulLeCam PaulLeCam merged commit 7319017 into MainframeOS:master Dec 5, 2019
@AuHau AuHau deleted the feat/better_errors branch December 5, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants