Only add MDNS services if MDNS is enabled (default=true) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonNelson
force-pushed
the
make-mdns-optional
branch
from
b736b9a to
5d5be3c
Compare
JonNelson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes MDNS optional if the HTTP or Telnet services are used. The defaults remain as they are today, but if someone (me) doesn't want to use MDNS then they shouldn't have to. Furthermore, I was chasing a crash where I wasn't calling
MDNS.begin(...)(only with the HTTP service). This is avoidable entirely if MDNS is not used.