Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Typstry.jl to v0.3.0 #55

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

jakobjpeters
Copy link
Contributor

See the Typstry.jl news for a detailed list of updates.

  • Fixes the Typst example (that I made in Implement Typst backend #48) incorrectly using ∂x instead of correctly using dx
  • Enables users to use typst"#set text(font: \"JuliaMono\")"
    • This typeface could be made the default in the preamble, but I'll leave that up to you :)

@jakobjpeters
Copy link
Contributor Author

I think that CI failed because the update isn't available everywhere yet.

src/rendering/typst.jl Outdated Show resolved Hide resolved
@jakobjpeters
Copy link
Contributor Author

Also, do you want to support only the latest Typstry.jl or previous versions too?

@asinghvi17
Copy link
Member

If Typstry.julia_mono requires v0.3.0, then I think it's fine to drop compat for the older versions. Thanks for the PR!

@jakobjpeters
Copy link
Contributor Author

Everything you're using is available back to v0.1.0, I'll test locally really quick.

@jakobjpeters
Copy link
Contributor Author

jakobjpeters commented Aug 13, 2024

I'm not sure what's up with the package server (if that is the issue), the new version was merged 8 hours ago. After 6 hours, I was only able to download the new version after doing pkg> registry up.

Setting versions to Typstry = "0.1, 0.2, 0.3" worked locally on all 3 documentation builds and had an infinite loop stalled for all 3 test suite runs.

@jakobjpeters
Copy link
Contributor Author

Hmm I was looking at the CI Build and deploy documentation, which seems like it's not finding v0.3.0 and failing there. But the CI Test seems to have installed it and stalled during testing.

@asinghvi17
Copy link
Member

Huh, this test suite thing is a real problem. I'll take a look locally later today.

@asinghvi17 asinghvi17 changed the base branch from master to typstry3 October 30, 2024 00:05
@asinghvi17 asinghvi17 merged commit 885e36a into MakieOrg:typstry3 Oct 30, 2024
asinghvi17 added a commit that referenced this pull request Nov 5, 2024
* Update Typstry.jl to v0.3.0 (#55)

* Update typst.jl

---------

Co-authored-by: Jakob Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants