Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Makie v0.20 #44

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Update to Makie v0.20 #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ed2b39
Increment Makie version
fbanning Nov 30, 2023
5b63f8b
Change resolution kwarg to size
fbanning Nov 30, 2023
8cd2397
Increment patch version
fbanning Nov 30, 2023
1109848
Update error type in test
fbanning Nov 30, 2023
6c361cc
Also ignore .osm files
fbanning Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
*.json
*.osm
Manifest.toml
*.code-workspace
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name = "OSMMakie"
uuid = "76b6901f-8821-46bb-9129-841bc9cfe677"
repo = "https://github.com/MakieOrg/OSMMakie.jl"
authors = ["Frederik Banning <[email protected]>"]
version = "0.0.7"
version = "0.0.8"

[deps]
GraphMakie = "1ecd5474-83a3-4783-bb4f-06765db800d2"
Expand All @@ -15,4 +15,4 @@ julia = "1.6"
GraphMakie = "0.5"
Graphs = "1.5"
LightOSM = "0.2"
Makie = "0.19"
Makie = "0.20"
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ download_osm_buildings(:bbox;
buildings = buildings_from_file("london_buildings.osm");

# plot London map with buildings
# also directly provide a figure resolution and limits for the plot
fig = Figure(; resolution = (1000,900))
# also directly provide a figure size and limits for the plot
fig = Figure(; size = (1000,900))
ax = fig[1,1] = Axis(fig;
limits = ((area.minlon, area.maxlon), (area.minlat, area.maxlat)),
autolimitaspect
Expand Down
2 changes: 1 addition & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ buildings = buildings_from_file(london_buildings);
end

# wrong recipe usage
@test_throws Makie.PlotMethodError osmplot(; osm)
@test_throws ErrorException osmplot(; osm)

@test begin # recipe with buildings and limits/autolimitaspect keywords
fig = Figure()
Expand Down
Loading