-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New beeswarm algorithm #27
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Anshul Singhvi <[email protected]>
This includes commits from #26 so that one should be merged first |
@@ -0,0 +1,127 @@ | |||
struct SimpleBeeswarm2 <: BeeswarmAlgorithm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename this? Maybe make this SimpleBeeswarm
and rename the current default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think that would be good. Do you actually still want to keep the current default given that it causes overlaps?
I noticed that the default algorithm is a bit buggy with overlaps, and it doesn't look ideal in the places without overlaps either. So I came up with my own version (I'm sure I just reinvented one of the ones out there, but whatever, was a fun exercise).
This one's as quick as the default but looks much more even, without overlaps.
Before
After